Update of bug #20541 (project freeciv):

                  Status:                    None => Ready For Test         
             Assigned to:                    None => jtn                    
         Planned Release:                         => 2.5.0                  


Follow-up Comment #2:

The problem is that the nationality happiness calculation added in patch #3628
does not preserve the number of citizens in cases of extreme unhappiness.
On the turn after this savegame (file #17282), pirates take over Westminster;
if you then look at its Happiness tab in the client, you can see that from
Nationality onwards, there are more citizens shown than there really are in
the city.
This can also been seen with Linz in file #17386 (immediately on load -- it
has recently been taken over).

The accounting in citizen_happiness_nationality() seems incomplete. Attached
patch copies the logic from citizen_happy_units(): "First make content =>
unhappy, then happy => unhappy, then happy => content."
It also has the same property of not creating angry citizens (notwithstanding
the comment /* FIXME: Why not? - Per */).

Is that the behaviour we want for nationality?

(file #17524)

Additional Item Attachment:

File name: trunk-nationality-unhappiness-accounting.patch Size:1 KB


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to