Summary: Generalise MR_BAD_TYPE_FOR_CITY_TAKE_OVER_BY_SEA
                 Project: Freeciv
            Submitted by: persia
            Submitted on: Sat 30 Mar 2013 06:47:00 PM GMT
                Category: general
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 



    The code surrounding tests for this movement failure reason makes
unsuitable assumptions about "Land" and "Ocean".  The attached patch
generalises it based on can_exist_at_tile() and can_attack_from_non_native. 
As part of this, the value is changed to
MR_BAD_TYPE_FOR_CITY_TAKE_OVER_FROM_NON_NATIVE, and the strings reported to
the client updated (and extended to include any movement-restricted unit
classes that have UCF_ATT_FROM_NON_NATIVE of which the client may wish to be
advised).  Testing with the classic and experimental rulesets shows no
difference beyond the text surrounding "Marines" in the message reported to
the client.


File Attachments:

Date: Sat 30 Mar 2013 06:47:00 PM GMT  Name: generalise-marine-takeovers.patch
 Size: 5kB   By: persia



Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to