URL:
  <http://gna.org/bugs/?21206>

                 Summary: nation_group_by_number() out-of-bounds check can
never fire
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Mon Oct 21 20:59:31 2013
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: In Progress
             Assigned to: jtn
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: Any
         Planned Release: 2.3.5,2.4.1,2.5.0,2.6.0

    _______________________________________________________

Details:

Spot the deliberate mistake in this out-of-bounds check:


  if (id < 0 && id >= num_nation_groups) {
    return NULL;
  }


Fortunately nothing currently relies on this being trapped (at least on trunk,
not thoroughly checked other branches).




    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?21206>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to