URL:
  <http://gna.org/patch/?4296>

                 Summary: Remove incorrect assertion for non-null nationality
                 Project: Freeciv
            Submitted by: silene
            Submitted on: Thu 07 Nov 2013 10:35:40 PM CET
                Category: client
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 

    _______________________________________________________

Details:

unit.c:unit_nationality checks that the nationality of the unit is non-null
before returning it. This assertion is incorrect since several places of the
server code purposely sets the nationality to null. (And the client code
expects the result of the function to be possibly null and test for it
anyway.) For example, when a diplomat investigates a city, there is a flood of
assertion failures in the console, since the nationality of enemy units is
always hidden from the clients.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 07 Nov 2013 10:35:40 PM CET  Name: nationality.patch  Size: 371B  
By: silene

<http://gna.org/patch/download.php?file_id=19333>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?4296>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to