Summary: Savegame loading doesn't honour REVEAL_MAP_DEAD
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Sat Nov 23 20:47:25 2013
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: Any
         Planned Release: 



In savegame.c:player_load_vision() and savegame2.c:sg_load_player_vision(),
map_know_and_see_all() is called unconditionally for dead players, even if the
'revealmap' option doesn't allow dead players to see the map.

(Also, the normal check in kill_player() prevents the map being revealed for
dead members of teams; again, this doesn't seem to be checked here.)

The system seems to take full advantage of the assumption that dead players
get to see the whole map (as they always used to):
savegame2.c:sg_save_player_vision() doesn't bother to save anything for dead
players. So, the fix isn't straightforward; there'll need to be special
handling for old savegames.
(I don't know if there's some reason it's hard to save the player map for dead
players -- perhaps stuff was thrown away or became invalid when they died?)


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to