Summary: server/edithand.c:handle_scenario_info() looks
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Sat Dec 14 15:48:30 2013
                Category: None
                Severity: 2 - Minor
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: Any
         Planned Release: 2.5.0,2.6.0



PACKET_SCENARIO_INFO is defined as a packet that can go both server->client
and client->server, but never actually goes in the c->s direction in practice.
Client edits to this information go in PACKET_EDIT_GAME instead.

It's been this way since r15698
<http://svn.gna.org/viewcvs/freeciv?revision=15698&view=revision>, RT #40229.
I'm guessing that this was the original plan for the editor before
PACKET_EDIT_GAME was added (r15701
<http://svn.gna.org/viewcvs/freeciv?revision=15701&view=revision>, bug #13452)
so now is vestigial.

Bug #13452 does say this:
> I'm not sure if the duplicated work in handle_scenario
> _info() and handle_edit_game() is ideal. Sure if there
> were a specialized gui widget for setting scenario
> parameters it would have to use the scenario info
> packet, but I think the property editor is enough


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to