Summary: No on-the-limit bonus for negative Size_Adj
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Wed 01 Jan 2014 07:25:25 PM EET
                Category: ai
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.4.2, 2.5.0, 2.6.0



This was missed in bug #21240 when I fixed Size_Unlimit & Size_Adj effects.
The effect being considered (not the one already active) gets extra bonus
value when city is already big enough to hit the current limit (size 8 city
considering building Aqueduct). That extra bonus is still given without
checking if effect being considered increases or decreases the limit. Attached
patch removed the bonus in case of negative change.

Noticed when debugging Alien ruleset problems in this area. "Basic
Infrastucture" gets positive value even for effect that makes -1 radiation
Size_Adj active in presence of Basic Infrastructure (so effects ((+2) + (-1))
for radiating tiles is considered better than (+2) for non-radiating tiles,
and FAR superior to what single (+1) would be)


File Attachments:

Date: Wed 01 Jan 2014 07:25:25 PM EET  Name: NegOnCitySizeLimit.patch  Size:
658B   By: cazfi



Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to