Summary: Do not send our own style bits to SDL_ttf
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Thu 02 Jan 2014 04:28:27 AM EET
                Category: client-sdl
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.5.0, 2.6.0



The problem with using SDL_ttf versions other than the one included in our
source tree is as follows:

We set the font style from the style definition of our own. This is done by
taking lowermost bits of our style to pass to SDL_ttf (our style & 0x0f). SDL
bits are 0, 1, and 2. Our centering bits are 3 and 4. So our bits are not
actually masked out but passed to SDL_ttf. Newer version of the SDL_ttf has
probably added "Overstrike" style to just one of these bits.

Attached patch simply gives our own bits values that are masked out when
sending style to SDL_ttf. This helps us out for now, but once more urgent
SDL(2)-client changes have been made, we should reorganice this code so that
we keep SDL_ttf style and our own style completely separate, and do not mask
out bits that SDL_ttf might some day uses itself.

For trunk this should be committed to SDL2-client too.


File Attachments:

Date: Thu 02 Jan 2014 04:28:27 AM EET  Name: SDLttfStyles.patch  Size: 766B  
By: cazfi



Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to