Summary: Conjunctive requirement sanity checking applied to
disjunctive building obsolete_by list
Submitted by: jtn
Submitted on: Fri Jan 3 01:45:14 2014
Severity: 3 - Normal
Priority: 5 - Normal
Status: In Progress
Assigned to: jtn
Discussion Lock: Any
Operating System: Any
In sanity_check_ruleset_data(), sanity_check_req_vec() is used for all
requirements lists, including pimprove->obsolete_by.
However, obsolete_by is a disjunctive ("or") list -- any of the requirements
is sufficient to obsolete the building. The checks currently in
sanity_check_req_vec() are only appropriate for "and" lists.
For instance, it's a bit of a stretch, but it would be possible to allow
either of two different Govs to obsolete a building, but the sanity checking
forbids it. (Two techs are more likely, but the ruleset checking allows
(Not that complex obsolete reqs are currently handled particularly gracefully
elsewhere, particularly in the help, but it would work in gameplay terms.)
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list