URL:
  <http://gna.org/patch/?4423>

                 Summary: Cleanup irrelevant CPPFLAGS from Makefiles
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sat 11 Jan 2014 10:57:51 AM EET
                Category: bootstrap
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.5.0, 2.6.0

    _______________________________________________________

Details:

Our Makefile.am's set many CPPFLAGS required for building against some
dependency library even when that particular Makefile.am has nothing to do
with the dependency. Attached patch cleans out such case (at least those I
noticed) This still works in Makefile.am level only - flags still get set for
all the source files in the directory if single source file needs them.

- MAPIMG_WAND_CFLAGS is needed in common/ only
- LUA_CFLAGS, LUASQL_CFLAGS, and TOLUA_CFLAGS are needed client side in
client/luascript/ only, not in main client/
- SOUND_CFLAGS are needed in main client/ only, not in individual
client/gui-xxx/ implementations

Targeting S2_5 also, as I want to keep these parts in sync between TRUNK &
S2_5 in case it's needed to ease porting of some clang build fixes.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 11 Jan 2014 10:57:51 AM EET  Name: CleanupCPPFlags.patch  Size: 8kB 
 By: cazfi

<http://gna.org/patch/download.php?file_id=19723>
-------------------------------------------------------
Date: Sat 11 Jan 2014 10:57:51 AM EET  Name: CleanupCPPFlags-S2_5.patch  Size:
7kB   By: cazfi

<http://gna.org/patch/download.php?file_id=19724>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?4423>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to