URL:
  <http://gna.org/bugs/?21495>

                 Summary: Airlift text parameter not used by all possible
formats
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Thu 16 Jan 2014 10:34:44 PM EET
                Category: client-gtk-2.0
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: Ready For Test
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.4.2, 2.5.0, 2.6.0

    _______________________________________________________

Details:

For both gtk2- and gtk3-client clang says:

client/gui-gtk-3.0/gotodlg.c:377:41: error: data argument not used by format
string [-Werror,-Wformat-extra-args]
             city_name(cities[i].city), air_text);
                                        ^

The format for this is selected from two possibilities, of which the other
takes just one parameter, ignoring air_text (which in that case is always
NULL).

Fix attached.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 16 Jan 2014 10:34:44 PM EET  Name: AirTextNullNotUsed.patch  Size:
2kB   By: cazfi

<http://gna.org/bugs/download.php?file_id=19761>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?21495>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to