URL:
  <http://gna.org/bugs/?21595>

                 Summary: Diplomat/Spy actions from the menu don't work
                 Project: Freeciv
            Submitted by: sveinung
            Submitted on: Tue 04 Feb 2014 06:40:30 PM GMT
                Category: client
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: Ready For Test
             Assigned to: sveinung
        Originator Email: 
             Open/Closed: Open
                 Release: 2.6.0, 2.5.0
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.6.0, 2.5.0

    _______________________________________________________

Details:

The Gtk client claim you can trigger Diplomat/Spy actions against the tile you
occupy using the menu (or the shortcut D). Nothing happens when you try to use
it.

The problem was a line failing silently unless the Spy/Diplomat action dialog
of another unit was open. It was probably meant to do the opposite.

The attached patch removes the check in stead of inverting it. No matter if
the check is there or not the Spy/Diplomat action dialog currently showing
will remain the same. Without the check the new actions will be queued in
stead of silently forgotten.

Not targeting this fix to 2.3 and 2.4 yet since it exposes some... interesting
behavior. When a Diplomat/Spy stand in an allied city and is asked to do
something that trigger a diplomat battle it will en up battling it self.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 04 Feb 2014 06:40:30 PM GMT  Name: ActionVSContainingCity.patch 
Size: 526B   By: sveinung

<http://gna.org/bugs/download.php?file_id=19961>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?21595>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to