Summary: Map canvas sliding after reconnecting
Submitted by: cazfi
Submitted on: Sun 16 Mar 2014 02:35:32 PM EET
Severity: 3 - Normal
Priority: 5 - Normal
Assigned to: None
Discussion Lock: Any
Operating System: None
I have not tried to setup actual test, but reading the sources...
Client remembers the old mapview canvas position so it can smoothly slide the
view when new position is set. There's two exceptions:
- When client is first started, static variable "first" in
center_tile_mapcanvas() tells that there's no old position to slide from
- set_mapview_scroll_pos() that's called for scroll bar handling disables
Neither of these seem to handle the case of client to remembering position
from the previous server when connecting new one. In theory this can result in
at least unnecessary sliding from randomish position to the position game
should start from. Worse things may happen if old server had bigger map than
new one and the client remembers position outside new map boundaries.
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list