URL:
  <http://gna.org/bugs/?21860>

                 Summary:  Trying to put the city style -1 into 8 bits when
connecting to server
                 Project: Freeciv
            Submitted by: sveinung
            Submitted on: Sun 23 Mar 2014 03:45:32 PM UTC
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: Ready For Test
             Assigned to: sveinung
        Originator Email: 
             Open/Closed: Open
                 Release: TRUNK
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.6.0

    _______________________________________________________

Details:

City style is sent as an UINT8. -1 is used when no city style is found.

The attached patch makes the city style 0 when no city stule was found. This
is the same behavior as when city_styles is NULL.

./fcser 
Encodings: Data=UTF-8, Local=UTF-8, Internal=UTF-8
This is the server for Freeciv version 2.5.99-dev
You can learn a lot about Freeciv at http://www.freeciv.org/
2: Loading rulesets.
2: AI*1 has been added as Easy level AI-controlled player (classic).
2: AI*2 has been added as Easy level AI-controlled player (classic).
2: AI*3 has been added as Easy level AI-controlled player (classic).
2: AI*4 has been added as Easy level AI-controlled player (classic).
2: AI*5 has been added as Easy level AI-controlled player (classic).
2: Now accepting new client connections.

For introductory help, type 'help'.
> 
2: Connection request from sveinung from localhost
2: c1 has client version 2.5.99-dev
2: sveinung has connected from localhost.
1: Trying to put -1 into 8 bits
2: Backtrace:
2:     0: ./server/freeciv-server(backtrace_print+0x22) [0x615be2]
2:     1: ./server/freeciv-server(vdo_log+0x78) [0x6192d8]
2:     2: ./server/freeciv-server(do_log+0x7d) [0x61936d]
2:     3: ./server/freeciv-server(dio_put_uint8+0x97) [0x53f107]
2:     4: ./server/freeciv-server() [0x59e3e6]
2:     5: ./server/freeciv-server() [0x49cb6f]
2:     6: ./server/freeciv-server() [0x48708b]
2:     7: ./server/freeciv-server(establish_new_connection+0x81a) [0x48843a]
2:     8: ./server/freeciv-server(handle_login_request+0x4de) [0x488b3e]
2:     9: ./server/freeciv-server(server_packet_input+0x325) [0x438875]
2:    10: ./server/freeciv-server(server_sniff_all_input+0x7ca) [0x4d1a8a]
2:    11: ./server/freeciv-server(srv_main+0x175) [0x439c45]
2:    12: ./server/freeciv-server(main+0x21e) [0x4322ce]
2:    13: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
[0x7f267a4d5b45]
2:    14: ./server/freeciv-server() [0x432cdf]
1: Trying to put -1 into 8 bits
2: Backtrace:
2:     0: ./server/freeciv-server(backtrace_print+0x22) [0x615be2]
2:     1: ./server/freeciv-server(vdo_log+0x78) [0x6192d8]
2:     2: ./server/freeciv-server(do_log+0x7d) [0x61936d]
2:     3: ./server/freeciv-server(dio_put_uint8+0x97) [0x53f107]
2:     4: ./server/freeciv-server() [0x59e3e6]
2:     5: ./server/freeciv-server() [0x49cb28]
2:     6: ./server/freeciv-server(send_player_info_c+0x7f) [0x49ccaf]
2:     7: ./server/freeciv-server(establish_new_connection+0x614) [0x488234]
2:     8: ./server/freeciv-server(handle_login_request+0x4de) [0x488b3e]
2:     9: ./server/freeciv-server(server_packet_input+0x325) [0x438875]
2:    10: ./server/freeciv-server(server_sniff_all_input+0x7ca) [0x4d1a8a]
2:    11: ./server/freeciv-server(srv_main+0x175) [0x439c45]
2:    12: ./server/freeciv-server(main+0x21e) [0x4322ce]
2:    13: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
[0x7f267a4d5b45]
2:    14: ./server/freeciv-server() [0x432cdf]
1: Trying to put -1 into 8 bits
2: Backtrace:
2:     0: ./server/freeciv-server(backtrace_print+0x22) [0x615be2]
2:     1: ./server/freeciv-server(vdo_log+0x78) [0x6192d8]
2:     2: ./server/freeciv-server(do_log+0x7d) [0x61936d]
2:     3: ./server/freeciv-server(dio_put_uint8+0x97) [0x53f107]
2:     4: ./server/freeciv-server() [0x59e3e6]
2:     5: ./server/freeciv-server() [0x49cb28]
2:     6: ./server/freeciv-server(send_player_info_c+0x7f) [0x49ccaf]
2:     7: ./server/freeciv-server(establish_new_connection+0x614) [0x488234]
2:     8: ./server/freeciv-server(handle_login_request+0x4de) [0x488b3e]
2:     9: ./server/freeciv-server(server_packet_input+0x325) [0x438875]
2:    10: ./server/freeciv-server(server_sniff_all_input+0x7ca) [0x4d1a8a]
2:    11: ./server/freeciv-server(srv_main+0x175) [0x439c45]
2:    12: ./server/freeciv-server(main+0x21e) [0x4322ce]
2:    13: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
[0x7f267a4d5b45]
2:    14: ./server/freeciv-server() [0x432cdf]
1: Trying to put -1 into 8 bits
2: Backtrace:
2:     0: ./server/freeciv-server(backtrace_print+0x22) [0x615be2]
2:     1: ./server/freeciv-server(vdo_log+0x78) [0x6192d8]
2:     2: ./server/freeciv-server(do_log+0x7d) [0x61936d]
2:     3: ./server/freeciv-server(dio_put_uint8+0x97) [0x53f107]
2:     4: ./server/freeciv-server() [0x59e3e6]
2:     5: ./server/freeciv-server() [0x49cb28]
2:     6: ./server/freeciv-server(send_player_info_c+0x7f) [0x49ccaf]
2:     7: ./server/freeciv-server(establish_new_connection+0x614) [0x488234]
2:     8: ./server/freeciv-server(handle_login_request+0x4de) [0x488b3e]
2:     9: ./server/freeciv-server(server_packet_input+0x325) [0x438875]
2:    10: ./server/freeciv-server(server_sniff_all_input+0x7ca) [0x4d1a8a]
2:    11: ./server/freeciv-server(srv_main+0x175) [0x439c45]
2:    12: ./server/freeciv-server(main+0x21e) [0x4322ce]
2:    13: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
[0x7f267a4d5b45]
2:    14: ./server/freeciv-server() [0x432cdf]
1: Trying to put -1 into 8 bits
2: Backtrace:
2:     0: ./server/freeciv-server(backtrace_print+0x22) [0x615be2]
2:     1: ./server/freeciv-server(vdo_log+0x78) [0x6192d8]
2:     2: ./server/freeciv-server(do_log+0x7d) [0x61936d]
2:     3: ./server/freeciv-server(dio_put_uint8+0x97) [0x53f107]
2:     4: ./server/freeciv-server() [0x59e3e6]
2:     5: ./server/freeciv-server() [0x49cb28]
2:     6: ./server/freeciv-server(send_player_info_c+0x7f) [0x49ccaf]
2:     7: ./server/freeciv-server(establish_new_connection+0x614) [0x488234]
2:     8: ./server/freeciv-server(handle_login_request+0x4de) [0x488b3e]
2:     9: ./server/freeciv-server(server_packet_input+0x325) [0x438875]
2:    10: ./server/freeciv-server(server_sniff_all_input+0x7ca) [0x4d1a8a]
2:    11: ./server/freeciv-server(srv_main+0x175) [0x439c45]
2:    12: ./server/freeciv-server(main+0x21e) [0x4322ce]
2:    13: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
[0x7f267a4d5b45]
2:    14: ./server/freeciv-server() [0x432cdf]




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 23 Mar 2014 03:45:32 PM UTC  Name: city_style_-1.patch  Size: 545B  
By: sveinung

<http://gna.org/bugs/download.php?file_id=20424>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?21860>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to