Follow-up Comment #1, bug #22022 (project freeciv):

I don't really like the idea of casting the int to a bool here: while I
certainly made a mistake in my boolean algebra ( !(A||B) != (!A && B)) as
compared to the similar construction in movement.c::unit_move_to_tile_test(),
in the event that this is applied (rather than the alternate solution in patch
#3901), I believe we ought be testing !(0 <
unit_class_transporter_capacity()), rather than
!unit_class_transporter_capacity().  An alternate solution would be to test 0
== unit_class_transporter_capacity(), although that doesn't as closely match
parallel tests in the code.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?22022>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to