URL:
  <http://gna.org/bugs/?22137>

                 Summary: Redundant check for existing mine in
execute_orders()
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Tue 03 Jun 2014 23:28:28 BST
                Category: None
                Severity: 2 - Minor
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: S2_5 r25043
         Discussion Lock: Any
        Operating System: Any
         Planned Release: 2.5.0

    _______________________________________________________

Details:

In execute_orders() on S2_5, in the following code added in patch #2206, the
second clause about mining looks like a duplicate:


        } else if ((ACTIVITY_MINE == activity
                    && tile_has_special(unit_tile(punit), S_MINE))   
                   || (ACTIVITY_IRRIGATE == activity
                       && (tile_has_special(unit_tile(punit), S_FARMLAND)
                           || tile_has_special(unit_tile(punit),
                                               S_IRRIGATION)))  
                   || (ACTIVITY_MINE == activity
                       && tile_has_special(unit_tile(punit), S_MINE))) {
          break; /* Already built, let's continue. */
        }


(trunk not affected as it's a different shape)




    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?22137>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to