URL:
<http://gna.org/patch/?4838>
Summary: Use UTYF_BADCITYDEFENDER in process_defender_want()
Project: Freeciv
Submitted by: persia
Submitted on: Mon 23 Jun 2014 09:43:47 AM JST
Category: ai
Priority: 5 - Normal
Status: Ready For Test
Privacy: Public
Assigned to: persia
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 2.6.0
_______________________________________________________
Details:
When UTYF_BADCITYDEFENDER was introduced in r10826, it appears that
process_defender_want() was not updated to use the new flag, and instead used
the old hardcoding to determine whether a given unit interacted sensibly with
walls. This hasn't been a bug, mostly because ruleset authors haven't
assigned DefendOK or DefendGood to UMT_SEA or UMT_BOTH units, but for rulesets
embracing complex nativity, it is more reasonable to restrict want based on
the flag than on the unit nativity (although it would be an oddity for a
ruleset author to give a DefendGood or DefendOK role to a unit type with a
BadCityDefender flag, so this may never be triggered in actual play).
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Mon 23 Jun 2014 09:43:47 AM JST Name:
use-UTYF_BADCITYDEFENDER-in-process_defender_want.patch Size: 3kB By:
persia
<http://gna.org/patch/download.php?file_id=21120>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?4838>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
