Summary: Allow Ferryboat as a starting unit
                 Project: Freeciv
            Submitted by: persia
            Submitted on: Sat 28 Jun 2014 06:45:33 PM JST
                Category: general
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: persia
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.6.0



    Ferryboats were initially blocked as starting units as a temporary measure
to work around the issue of starting units being placed in inappropriate
terrain (r8490).  When this was resolved (r12456), the temporary limitation
was not lifted.

    The attached patch lifts this restriction, and adds a new test when
setting the startunits string to verify that the first unit will be native to
a terrain used when selecting starting positions (as otherwise, there may be
an infinite loop seeking for a suitable startpos for the player).  As a side
effect, when considering radically different rulesets, a startunits string
suitable for one may be unsuitable for another, which may be exposed to a
player as an inability to enter "set startunits fac\n rulesetdir
land-ferries\n" when "rulesetdir land-ferries\n set startunits fac\n" works.

    This patch also fixes the startunits help and code comments to reflect the
changes from patch #3352 (r21435).


File Attachments:

Date: Sat 28 Jun 2014 06:45:33 PM JST  Name:
allow-ferryboat-as-a-starting-unit.patch  Size: 7kB   By: persia



Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to