Summary: QT client strings unsuitable for i18n
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Sat 12 Jul 2014 13:36:29 BST
                Category: client-qt
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: S2_5 r25502
         Discussion Lock: Any
        Operating System: Any
         Planned Release: 



I've noticed a number of constructs in the Qt client that aren't really
suitable for i18n.

It probably wants a blanket review, ideally before too many translators spend
time on the current strings.

1. Sentences assembled out of fragments by string concatenation rather than
using format strings.

    unit_label1 = unit_label1 + " " + _("from") + " ";

    techs_known = QString("<b>") + _("Techs unknown by") + sp
                  + QString(nation_adjective_for_player(pplayer)) + sp
                  + QString(_("nation")) + QString("</b> :");

2. Non-generalised pluralisation.

  if (unit_list_size(punits) == 1) {
    ask.setText(_("Are you sure you want to disband that unit?"));
  } else {
    str = QString(_("Are you sure you want to disband those %1 units?")).arg


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to