Follow-up Comment #1, patch #4940 (project freeciv):

> so the callers may use a locally-scoped universal, rather than
> a malloc()'d universals_u,

What prevented thay previously? From the patch it seems that the function did
not made any assumptions if the pointer received was dynamically allocated
memory or local, though the caller you have adjusted for some reason (or
no-reason?) did it with fc_malloc(). OTOH you now change it to be
passed-by-value rather than by pointer. I think all that makes is making it
less efficient (copying of the full structure in every function call, and
maybe also before) and harder to pass something caller originally has as
pointer (such as getting memory with fc_malloc())


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to