Update of patch #4940 (project freeciv):

                  Status:          Ready For Test => In Progress            


Follow-up Comment #2:

I'm not sure anything prevented using a locally scoped variable before, but
whenever I tried to do that, I got lost (with either compilation failures or
runtime issues).  The method I propose is mostly just easier for me to
comprehend, and for ease of extension, I think all the callers ought have the
same format (ideally we can collapse
these into a single function in the future, perhaps with macros for access

Thinking about this in terms of optimisation, the introduction of the runtime
switch to determine fulfills is another source of slowness, as compared to the
previous implementation.  I think I'll try to find another way to reduce the
apparent complexity of extending this to new requirement kinds that doesn't
have the same performance impact.


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to