Summary: dai_effect_value() to return single effect value
Submitted by: cazfi
Submitted on: Wed 23 Jul 2014 12:54:18 AM EEST
Priority: 5 - Normal
Status: Ready For Test
Assigned to: None
Discussion Lock: Any
Planned Release: 2.6.0
"I would prefer this to be changed in trunk so that dai_effect_value()
returned value of the effect being evaluated. Current interface may have made
sense in some distant past, but currently it only complicates things - the
incoming old value is used for nothing but to be added, so the addition would
be as easily be done in caller side. In case of present = FALSE effects caller
needs to calculate the delta out of value that went in to dai_effect_value()
and value that came out.
And then there's the semantical point that function name no way indicate that
it returns something else than the value of the effect."
Date: Wed 23 Jul 2014 12:54:19 AM EEST Name:
DaiEffectValueCleanFingerprint.patch Size: 5kB By: cazfi
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list