URL: <http://gna.org/patch/?4974>
Summary: dai_effect_value() to return single effect value Project: Freeciv Submitted by: cazfi Submitted on: Wed 23 Jul 2014 12:54:18 AM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 _______________________________________________________ Details: bug #22363: "I would prefer this to be changed in trunk so that dai_effect_value() returned value of the effect being evaluated. Current interface may have made sense in some distant past, but currently it only complicates things - the incoming old value is used for nothing but to be added, so the addition would be as easily be done in caller side. In case of present = FALSE effects caller needs to calculate the delta out of value that went in to dai_effect_value() and value that came out. And then there's the semantical point that function name no way indicate that it returns something else than the value of the effect." Implementation attached. _______________________________________________________ File Attachments: ------------------------------------------------------- Date: Wed 23 Jul 2014 12:54:19 AM EEST Name: DaiEffectValueCleanFingerprint.patch Size: 5kB By: cazfi <http://gna.org/patch/download.php?file_id=21513> _______________________________________________________ Reply to this item at: <http://gna.org/patch/?4974> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev