URL:
<http://gna.org/patch/?5035>
Summary: Make key_unit_diplomat_actions() dumber
Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 13 Aug 2014 02:53:21 PM UTC
Category: None
Priority: 5 - Normal
Status: Ready For Test
Privacy: Public
Assigned to: sveinung
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 2.6.0
_______________________________________________________
Details:
Before spy acting against own tile key_unit_diplomat_actions() will check that
there is a city on it. At the moment this check isn't wrong. Spy actions vs
units that aren't alone on their tile are illegal. The only other target type
is cities. It could even be said to be slightly beneficial: if a client that
would ask that a unit acts against its own tile and no city is present will
save a round trip to the server. No current client will ask.
The problem with the check is that its hard to discover. It could cause issues
if existing actions vs units are changed to no longer require the unit to
alone at its til or new actions are added. Remove it.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Wed 13 Aug 2014 02:53:21 PM UTC Name:
0003-Prepare-for-ability-to-target-a-unit-that-is-t-alone.patch Size: 1kB
By: sveinung
<http://gna.org/patch/download.php?file_id=21708>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?5035>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
