URL:
<http://gna.org/bugs/?22624>
Summary: Got "Goto with HOVER_NONE?" error message
Project: Freeciv
Submitted by: pepeto
Submitted on: dim. 14 sept. 2014 12:04:40 CEST
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
Status: Ready For Test
Assigned to: pepeto
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: Any
Planned Release: 2.4.4, 2.5.0-beta2, 2.6.0
_______________________________________________________
Details:
Error messages:
0: in fill_client_goto_parameter() [client/goto.c::806]: assertion
'hover_state != HOVER_NONE' failed.
0: Goto with HOVER_NONE?
0: Please report this message at http://gna.org/projects/freeciv/
Backtrace:
(gdb) bt full
#0 0x00007ffff5fc620b in raise (sig=2)
at ../nptl/sysdeps/unix/sysv/linux/pt-raise.c:37
resultvar = 0
pid = <optimized out>
#1 0x00000000005eef82 in fc_assert_fail (file=file@entry=0x613405 "goto.c",
function=function@entry=0x613790 <__FUNCTION__.22126>
"fill_client_goto_parameter", line=line@entry=806,
assertion=assertion@entry=0x6134a7 "hover_state != HOVER_NONE",
message=message@entry=0x613491 "Goto with HOVER_NONE?") at log.c:520
level = LOG_FATAL
#2 0x000000000047f5a7 in fill_client_goto_parameter (
punit=punit@entry=0x32dba10, parameter=parameter@entry=0x7fffffffd280,
initial_mp=initial_mp@entry=0x7fffffffd278,
connect_speed=connect_speed@entry=0x7fffffffd27c) at goto.c:806
__FUNCTION__ = "fill_client_goto_parameter"
#3 0x0000000000481bb8 in send_goto_tile (punit=punit@entry=0x32dba10,
ptile=0x264af20) at goto.c:1094
dummy1 = 1
dummy2 = 0
parameter = {start_tile = 0x2649e40, moves_left_initially = 0,
fuel_left_initially = 1, move_rate = 9, fuel = 1, owner = 0x177f640,
uclass = 0x9e9ba0 <unit_classes+320>, unit_flags = {
vec = "\000\000\000\000\b\000\000"}, omniscience = false,
get_MC = 0x608670 <seamove>, unknown_MC = 6, get_TB = 0x0,
get_EC = 0x47f1a0 <get_EC>,
can_invade_tile = 0x5d5e70 <player_can_invade_tile>, get_zoc = 0x0,
is_pos_dangerous = 0x0, get_moves_left_req = 0x0, get_costs = 0x0,
data = 0x6}
pfm = <optimized out>
path = <optimized out>
#4 0x0000000000477341 in request_move_unit_direction (
punit=punit@entry=0x32dba10, dir=<optimized out>) at control.c:1472
dest_tile = <optimized out>
#5 0x0000000000479ed8 in key_unit_move (gui_dir=gui_dir@entry=DIR8_SOUTH)
at control.c:2655
map_dir = <optimized out>
punit_iter = 0x0
punit = 0x32dba10
__FUNCTION__ = "key_unit_move"
#6 0x00000000004470f7 in key_press_map_canvas (w=<optimized out>,
ev=0x1581f50, ev=0x1581f50, data=<optimized out>) at gui_main.c:518
No locals.
#7 toplevel_key_press_handler (w=<optimized out>, ev=0x1581f50,
data=<optimized out>) at gui_main.c:652
w = <optimized out>
data = <optimized out>
ev = 0x1581f50
[...]
For bug #21932, the added checks are not right. In the case the case the user
want to use the function send_goto_tile() or path_to_nearest_allied_city(),
'hover_state' may be not set.
But worse, if the 'hover_state' is set (HOVER_CONNECT for example), then will
fill the parameter for it, even if we just to return to nearest allied city.
I don't think this would be the cause of bug #21774 however.
Fix attached, making separate functions goto_fill_parameter_base() and
goto_fill_parameter_full().
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: dim. 14 sept. 2014 12:04:40 CEST Name: trunk_goto_fill_parameter.patch
Size: 5 ko By: pepeto
<http://gna.org/bugs/download.php?file_id=22189>
-------------------------------------------------------
Date: dim. 14 sept. 2014 12:04:40 CEST Name: S2_5_goto_fill_parameter.patch
Size: 5 ko By: pepeto
<http://gna.org/bugs/download.php?file_id=22190>
-------------------------------------------------------
Date: dim. 14 sept. 2014 12:04:40 CEST Name: S2_4_goto_fill_parameter.patch
Size: 5 ko By: pepeto
<http://gna.org/bugs/download.php?file_id=22191>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?22624>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
