Update of patch #5357 (project freeciv):
Category: None => general
Status: None => Ready For Test
Planned Release: => 2.4.4, 2.5.0, 2.6.0
_______________________________________________________
Follow-up Comment #3:
Thank you for your help very much!
Notes on your patch:
* we don't need to have an array [2] for boolean 'allow_prereqs' because it is
not supposed to be modified in the body of the function;
* as we are looking for the first FALSE return, then it is useless to cache
the results.
When working, I noticed a possible bug: e.g. when an advance as a self-rooted
technology as parent (not root), the tech is marked as reachable, even if its
parent isn't. I think this was supposed to work with the HACK in
server/ruleset.c. But a tech may requires many roots (through parents).
My patches include the fix for that bug. It shortcuts the deep introspection
when a tech is known. It also removes the usage of recursive calls for
XXX_invention_recheable().
(file #22674, file #22675)
_______________________________________________________
Additional Item Attachment:
File name: trunk_research_invention_reachable.patch Size:2 KB
File name: S2_4_S2_5_player_invention_reachable.patch Size:5 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?5357>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
