Follow-up Comment #8, bug #23009 (project freeciv):
Looks nice, but do you want to upgrade that dialog ( add properties for units
and links, choose correct font taken from settings and so on) ?
And first, it doesnt compile under linux without some changes:
- setTopicExtra it invokes extra_type_by_translated_name which doesnt exist at
all ( it could compile cause that code is unreachable anyway)
- case HELP_EXTRA and HELP_MULTIPLIER - those doesnt exist too
- missed HELP_BASE and HELP_ROAD
Why its better to run on linux ? configure is probably at least 10 times
faster than on gnuwin32
Compiling too because each enter directory XXX takes so much time on windows
About rest some minor stuff:
- there is one invocation of tr("Manual") instead _("Manual")
- missing comment //client before #include "helpdata.h"
- Qt includes are not divided on QtCore and QtGui in rest of code
- there is no variables starting with _ in freeciv code so
they should not be there too
- functions are named in C style ( or whatever it is - like set_topic insted
setTopic)
- variables should be declared in start of block of function, not in middle
like QTreeWidgetItem *item in makeTree()
and btw fastest way to do proper formatting is probably run
that indent -kr -i2 -l77 first, then some C++ formatter to fix templates, then
manually fix all "} xxx_iterate_end"
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?23009>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
