Follow-up Comment #4, bug #23072 (project freeciv):
I think this bug is related to bug #23068, and that it is caused by patch
#5520, where the way barbarians are loaded from savegames does not keep
compatibility with savegames from before that change.
So when someone has previously saved a game on a SVN revision from before
27185, then a new server is build on SVN revision 27280 (which includes patch
#5520), then somehow no barbarian nations are found in try_summon_barbarians()
and the server gets a segmentation fault in player_nation_defaults().
>This is a bit far-fetched, but is it possible that you have patch #5521
accidentally (it was not in freeciv-web patch list) applied to your tree?
First version of that patch caused exactly the kind of crash you're
experiencing.
No, this is a regular Freeciv-web server without any additional patches.
>Any other instructions about reproducing? Is this with specific scenario, or
not scenario at all? Can you reproduce reliably yourself?
To reproduce, create a savegame on Freeciv-web with a Freeciv server from
before SVN revision 27279, then try to load that savegame with a server from
after SVN revision 27279, end turns until try_summon_barbarians() is called,
and you will get a segmentation fault.
I suggest a short-term fix would be to prevent the segmentation fault by not
creating barbarians if try_summon_barbarians() would have caused a
segmentation fault if called, and a more long-term solution would be for the
savegame loading code to load savegames from both before and after SVN
revision 27279.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?23072>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
