Follow-up Comment #3, patch #5913 (project freeciv):
It then seems that freeciv-web protocol is not symmetric in a sense that
server->proxy has different packet structure to what proxy->server has. The
patch includes some changes that were necessary for handling packets sent by
the server (like in server->proxy protocol). Now you are saying that they
actually break receiving packets from freeciv-web proxy (proxy->server)? I
think this patch can be broken to a couple of separate changes:
1) Shifting the buffer (where previously was a no-op memmove() with the same
source and dest + simply marking the buffer empty)
2) json_loadb() buffer length correction, not including raw-protocol header &
terminating NULL (handling of that NULL is what I suspect most)
3) Change to checking the minimum length of the buffer to be sane. That's
actually an overdue change from the time we removed the unused 'type' from the
packet header. The whole code-block is now actually obsolete (we've already
read the 'length', no point to check if we've got it) but I didn't remove it
in this patch as an unrelated change
> no packets could be sent to or from the Freeciv server
Umh, the change is in receiving side only. So how could that affect sending?
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?5913>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
