URL:
<http://gna.org/bugs/?23503>
Summary: Inconsistency in ocean border claiming next to
border source
Project: Freeciv
Submitted by: jtn
Submitted on: Sun 19 Apr 2015 15:46:16 BST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.3.5, 2.4.4, 2.5.0
Discussion Lock: Any
Operating System: Any
Planned Release: 2.4.5, 2.5.1, 2.6.0, 3.0.0
_______________________________________________________
Details:
Spurred by patch #5987 and wiki grumbling
<http://www.freeciv.org/wiki/Talk:Territory#Gross_inconsistencies_with_water>,
I've been looking at is_claimable_ocean() and environs.
I think the two rules "can be claimed if adjacent to border source" and
"cannot be claimed if adjacent to two continents" fight each other; whichever
condition is encountered first wins. This probably manifests as tiles on one
side of a city being claimable. Certainly the picture on the wiki is
consistent with this.
I think it's been like this since at least 2.1.
Two obvious fix proposals:
* Adjacent border-source wins (so don't bail out of the iteration if two
adjacent continents are detected). This most closely matches documented
behaviour.
* Two-continents wins (preventing a peaceful city closing off a narrow
shipping lane). (However, this doesn't prevent cities bordering open ocean
blocking your Triremes, so probably isn't worth it.)
(When fixing this, be careful not to break the property that small inlets on
continents other than that of the border source can't be claimed -- this is
provided by the initialisation of cont1, and is important to match the land
rule that border sources can't claim remote islands in map_claim_border().)
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?23503>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
