Update of bug #23420 (project freeciv):
Category: client-gtk-2.0 => client
Planned Release: => 2.5.1, 2.6.0, 3.0.0
_______________________________________________________
Follow-up Comment #3:
Looks good. Only a couple of minor nitpicks to reach perfection:
- I'm not even sure if this is mentioned in the CodingStyle, but "*" of the
pointer is usually attached to the name of the variable, not to the type:
struct player* plr -> struct player *plr
- While it's legal C, avoid using name of the structure as name of the
variable:
struct player *player -> struct player *plr
- Add comment to where you check if player is global observer or the nation is
the player self, that the 0 returned will sort player's own nation above all
others (I think)
--
Sveinung was first maintainer to comment this. I assume you want to take the
ticket?
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?23420>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
