Follow-up Comment #17, bug #18200 (project freeciv):
Marko, thank you for feedback.
I'll upload an updated patch later today.
> - qt5-darwin.m4 needs to be added to Makefile.am
I'll do.
> - In FC_QT5_DARWIN_COMPILETEST value of CPPFADD seems suspicious (but I
don't have Mac to test this) in case of default path (no "$1" given). Does it
really not need any of those -D)efined macros that you give with custom path
case?
> - Similarly FC_QT5_DARWIN_LINKTEST / LIBSADD seems completely different in
case of default path compared to custom path case
I suppose we should remove cases of empty path because the build process will
fall if the QT path was not specified.
Moreover there is no way find QT framework if it was not specified by command
line.
I will not run any checks if the path to framework was not been specified.
> - "/Users/al/" seems like your own path, not something that we can use as a
default
This is a sad mistake. I'm really sorry for that.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?18200>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
