Follow-up Comment #15, patch #6104 (project freeciv):
Thank you for the new revision. I hope the slow progression isn't too
frustrating.
_+ notify_player(player_by_number(i), unit_tile(punit),
E_UNIT_ESCAPED,
+ ftc_server,"Some of your unit/units are escaped from"_
"are escaped"?
Remember space. (See our coding style)
Don't start a scope with a blank line.
_+ {"E_UNIT_ORDERS", NULL, E_S_UNIT, N_("Unit was escaped from attacker"),
NULL, E_UNIT_ESCAPED}_
Please don't expand the macro manually. It makes it impossible to change
everything by changing the macro. It also makes the line to long.
"was escaped"?
_- wipe_unit(punit2, ULR_KILLED, pvictor);
+ wipe_unit(punit2, ULR_KILLED, pvictor); _
This inserts a tab at the end of the line.
Where are the comment in units.ruleset? The comments were present for some
rulesets in version 4. Feed back on what ended up in patch 4: The flags should
be documented everywhere unit type flags are documented. There shouldn't be
any blank line between comments. Your patch shouldn't add the flag to any
units.
Tips: Working with patches manually is time consuming. You can use git (or a
similar tool) to do it automatically.
Do you want to support AI in this patch? AI support could come in a follow up
patch.
On the bright side: I was able to get far into an autogame with your patch
applied when no unit types had any of the new flags.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?6104>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
