URL:
<http://gna.org/bugs/?23716>
Summary: "Trying to update old city (wrong identity)..."
Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 27 Jul 2015 11:55:47 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: TRUNK r29241
Discussion Lock: Any
Operating System: None
Planned Release: 2.5.1, 2.6.0, 3.0.0
_______________________________________________________
Details:
With attached autogame TRUNK r29241 says
"Trying to update old city (wrong identity) at 47,35 for player Börte"
on turn 659.
Backtrace (some line numbers can be a bit off due to added debugging code):
#2 0x00000000004b5475 in update_dumb_city (pplayer=0x2a04380,
pcity=0x24e0780)
at server/citytools.c:2410
#3 0x00000000004b3f7e in broadcast_city_info (pcity=0x24e0780) at
server/citytools.c:2047
#4 0x00000000004b437c in send_city_info (dest=0x0, pcity=0x24e0780) at
../../server/citytools.c:2125
#5 0x00000000004c0a6d in update_city_activity (pcity=0x24e0780) at
server/cityturn.c:2934
#6 0x00000000004b9156 in update_city_activities (pplayer=0xd35540) at
server/cityturn.c:591
#7 0x00000000004396f2 in end_phase () at server/srv_main.c:1142
#8 0x000000000043dd2a in srv_running () at server/srv_main.c:2592
#9 0x000000000043f4ce in srv_main () at server/srv_main.c:3103
#10 0x0000000000431a1a in main (argc=6, argv=0x7fffffffe0e8) at
server/civserver.c:459
I don't know what happens there overall - why that player hasn't got playermap
updated to contain correct city before, though sees the tile now.
In any case, reality_check_city() is supposed to be used by the callers of
update_dumb_city() to make sure this does not happen under any circumstances.
Attached fix does that.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Mon 27 Jul 2015 11:55:47 AM EEST Name: updtoldcity.serv Size: 383B
By: cazfi
<http://gna.org/bugs/download.php?file_id=24671>
-------------------------------------------------------
Date: Mon 27 Jul 2015 11:55:47 AM EEST Name: RealityCheckBroadcasted.patch
Size: 1kB By: cazfi
<http://gna.org/bugs/download.php?file_id=24672>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?23716>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
