URL:
<http://gna.org/patch/?6321>
Summary: Make actor unit type check clearer
Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 04 Sep 2015 03:28:37 PM UTC
Category: general
Priority: 5 - Normal
Status: Ready For Test
Privacy: Public
Assigned to: sveinung
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 3.0.0, 2.6.0
_______________________________________________________
Details:
The function is_actor_unit() may give the impression that the check is for the
unit rather than the unit type.
It is easy to ignore the unit type part of the name is_actor_unit_type().
Replace the both with utype_may_act_at_all()
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Fri 04 Sep 2015 03:28:37 PM UTC Name: 3.0-utype_may_act_at_all.patch
Size: 10kB By: sveinung
<http://gna.org/patch/download.php?file_id=25053>
-------------------------------------------------------
Date: Fri 04 Sep 2015 03:28:37 PM UTC Name: 2.6-utype_may_act_at_all.patch
Size: 9kB By: sveinung
<http://gna.org/patch/download.php?file_id=25054>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?6321>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev