Update of bug #23956 (project freeciv): Status: In Progress => Ready For Test
_______________________________________________________ Follow-up Comment #2: Use the already existing actor_id and target_id when unit_perform_action() checks that actor and target survived the Lua. The checks in the action doer functions are redundant because of the checks in unit_perform_action(). Drop them. Drop the check in do_unit_disband(). It is called by handle_unit_disband() and unit_do_disband_trad(). handle_unit_disband() gets its unit by looking it up by id. unit_do_disband_trad() will return before the call if it manages to disband the unit. (file #25396, file #25397) _______________________________________________________ Additional Item Attachment: File name: 3.0-Don-t-get-the-id-from-a-potentially-dead-struct.patch Size:12 KB File name: 2.6-Don-t-get-the-id-from-a-potentially-dead-struct.patch Size:6 KB _______________________________________________________ Reply to this item at: <http://gna.org/bugs/?23956> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev