URL:
  <http://gna.org/bugs/?23998>

                 Summary: best_act used uninitialized in autosettlers -warning
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Wed 28 Oct 2015 11:42:11 PM EET
                Category: ai
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: None
         Planned Release: 

    _______________________________________________________

Details:

From bug #23993:

In autosettlers.c
autosettlers.c:888:7: warning: variable 'best_act' is used uninitialized
whenever 'if' condition is false [-Wsometimes-uninitialized]
  if (unit_has_type_flag(punit, UTYF_SETTLERS)) {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
autosettlers.c:901:38: note: uninitialized use occurs here
                          best_tile, best_act, &best_target,
                                     ^~~~~~~~
autosettlers.c:888:3: note: remove the 'if' if its condition is always true
  if (unit_has_type_flag(punit, UTYF_SETTLERS)) {
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
autosettlers.c:837:3: note: variable 'best_act' is declared here
  enum unit_activity best_act;
  ^





    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?23998>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to