URL:
<http://gna.org/bugs/?24052>
Summary: Science report progress bar crash when research not
set
Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 08 Nov 2015 08:50:47 PM EET
Category: client-sdl2
Severity: 3 - Normal
Priority: 5 - Normal
Status: Ready For Test
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release: 2.5.2, 2.6.0, 3.0.0
_______________________________________________________
Details:
Checking through a drawing code crash backtrace I noticed that if research is
not set, sdl-clients' science dialog will consider current research cost zero
and try to adjust things for zero width progress bar. This is at least one
possible explanation for the crash I saw.
Fix attached, also avoiding divide by zero (if cost is 1 - would not occur in
any of the known rulesets) problem the old code had.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Sun 08 Nov 2015 08:50:47 PM EET Name: ScienceReportAUnset.patch Size:
2kB By: cazfi
<http://gna.org/bugs/download.php?file_id=25676>
-------------------------------------------------------
Date: Sun 08 Nov 2015 08:50:47 PM EET Name: ScienceReportAUnset-S2_6.patch
Size: 5kB By: cazfi
<http://gna.org/bugs/download.php?file_id=25677>
-------------------------------------------------------
Date: Sun 08 Nov 2015 08:50:47 PM EET Name: ScienceReportAUnset-S2_5.patch
Size: 3kB By: cazfi
<http://gna.org/bugs/download.php?file_id=25678>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24052>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
