URL: <http://gna.org/bugs/?24059>
Summary: Citydlg prev/next sensitivity for global observer not good Project: Freeciv Submitted by: cazfi Submitted on: Mon 09 Nov 2015 03:21:02 AM EET Category: client-gtk-3.0 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: _______________________________________________________ Details: Reading city_dialog_update_prev_next() and even create_city_dialog() sensitivity setting part, it seems that global observers are not handled very well. I think there's some reversed checks (otherwise "global observer or not city owner" could drop the first part as global observer does not own any cities) I also wonder if some other place takes care that no two dialogs point to same city, so city_dialog_update_prev_next() logic to just count dialogs work to tell number of *different* dialogs. What about diplomat investigating enemy cities at the same time? Do those dialogs count? _______________________________________________________ Reply to this item at: <http://gna.org/bugs/?24059> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev