URL:
<http://gna.org/bugs/?24325>
Summary: New terrain types in a ruleset can mess terrident
map usage on loading of old savegame
Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 18 Jan 2016 09:31:06 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: Ready For Test
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release: 2.6.0, 3.0.0
_______________________________________________________
Details:
Terrain identifiers are required to be unique within a version of a ruleset.
Terrident map in a savegame lists mapping for those terrain types that existed
at the time of savegame creation.
Currently savegame loading code completes terrident mapping by using current
identifiers for the rest of the terrains. This can lead to a duplicate
identifier when a new terrain has been added to the ruleset since the savegame
creation and identifiers are rearranged so that this new terrain now has
identifier that was used for some terrain in savegame creation time.
For one terrain the identifier would be read from the savegame, and the new
one, not present in the savegame at all, would get it from the current ruleset
version.
Attached fix is as simple as not completing the terrident mapping for new
terrains. There should be no references to them in a savegame that was created
when they were not available in the ruleset at all.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Mon 18 Jan 2016 09:31:06 PM EET Name: IdLoadForAllExisting.patch Size:
2kB By: cazfi
<http://gna.org/bugs/download.php?file_id=26371>
-------------------------------------------------------
Date: Mon 18 Jan 2016 09:31:06 PM EET Name: IdLoadForAllExisting-S2_6.patch
Size: 850B By: cazfi
<http://gna.org/bugs/download.php?file_id=26372>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24325>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
