URL:
<http://gna.org/patch/?6836>
Summary: fc_prehdrs.h to include winsock headers first
Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 22 Jan 2016 03:16:51 PM EET
Category: bootstrap
Priority: 5 - Normal
Status: Ready For Test
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 2.6.0, 3.0.0
_______________________________________________________
Details:
On MSYS2 compilations one needs to include winsock2.h before ANSI C headers,
or not to be included at all. They conflict with each other, but if winsock2.h
is included first, standard headers know how to adapt.
Attached patch works toward correct include order by introducing
utility/fc_prehdrs.h. The idea is to collect such include order problems to
that one header instead of every individual source file.
Alone this patch doesn't do much good, fc_prehdrs.h being included only to
astring.c (first source file in the compilation order that suffered from the
problem) but I still would commit it already before going through all the
source files. Testing this in various systems should already expose any major
problems, before going through all the work of full implementation.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Fri 22 Jan 2016 03:16:51 PM EET Name: FcPreHdrs.patch Size: 2kB By:
cazfi
<http://gna.org/patch/download.php?file_id=26414>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?6836>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
