URL:
<http://gna.org/bugs/?24629>
Summary: Gtk-clients not disconnecting from server on quit
Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 01 May 2016 04:07:13 PM EEST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
Status: Ready For Test
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release: 2.5.5, 2.6.0, 3.0.0
_______________________________________________________
Details:
Unlike with "Leave Game", gtk-clients do not make controlled disconnect from
the server with "Quit Game" at all. This has a couple of consequences:
- Server side usually learns about the fact only via ping timeouts and such ->
information shown to other players not so good as it could
- Valgrind gives a lot of warnings about unfreed packet hashes (delta
protocol) etc.
Fix attached. Not targeting to 2.5.4 (this can change, depending on for
example what kind of opportunities I have for making Windows test builds).
Plan is to commit to other branches soon anyway.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Sun 01 May 2016 04:07:13 PM EEST Name: DisconnectOnQuit.patch Size:
2kB By: cazfi
<http://gna.org/bugs/download.php?file_id=27253>
-------------------------------------------------------
Date: Sun 01 May 2016 04:07:13 PM EEST Name: DisconnectOnQuit-S2_6.patch
Size: 2kB By: cazfi
<http://gna.org/bugs/download.php?file_id=27254>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24629>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
