URL:
  <http://gna.org/patch/?7200>

                 Summary: Drop special extra checks for barbarians from
differnent players_xxx() diplstate checks
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sun 08 May 2016 08:28:42 PM EEST
                Category: general
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.6.0, 3.0.0

    _______________________________________________________

Details:

Checking if player is barbarian should not be necessary in any of the
players_non_invade() & similar functions as barbarians should have their
diplstate always set to DS_WAR with everyone.

It would be nice to drop also some of the pplayer1 == pplayer2 checks and see
that players diplstate with him/herself is DS_ALLIANCE instead. (Also, I
wonder what breaks because often only DS_ALLIANCE is checked, and DS_TEAM is a
different value...)



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 08 May 2016 08:28:42 PM EEST  Name: BarbariansNonInvade.patch  Size:
3kB   By: cazfi

<http://gna.org/patch/download.php?file_id=27341>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?7200>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to