URL:
<http://gna.org/bugs/?24714>
Summary: Cannot change production in new city after
disbanding unit there
Project: Freeciv
Submitted by: jtn
Submitted on: Sat 28 May 2016 02:58:24 PM BST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.5.4
Discussion Lock: Any
Operating System: Any
Planned Release: 2.5.5, 2.6.0, 3.0.0
Contains string changes: No
_______________________________________________________
Details:
Reported by fomalhaut on the forum
<http://forum.freeciv.org/f/viewtopic.php?f=8&t=855&p=4943>:
> In the turn when I built a city, I disbanded a unit in the city and then I
was prevented to change current worklist.
> Changing worklist should be always allowed.
> And in this case, displayed message is Inappropriate.
> "You have bought this turn, can't change."
> (We can't buy in the turn we built a city.)
I agree that it's buggy that you can't change production the turn a city is
founded after you've added shield stock to it by disbanding.
I think the fix is as simple as creating cities with did_buy=FALSE. Currently
they are created with did_buy=TRUE, with comment
/* You cannot buy production same turn city is founded */, but that condition
is separately checked (since r4945 in 2002
<http://svn.gna.org/viewcvs/freeciv?revision=4945&view=revision>) so it no
longer seems necessary; and did_buy is also checked in
city_can_change_build(), causing this bug.
The condition in that function is (!pcity->did_buy || pcity->shield_stock <=
0), which is why we don't run into this all the time (usually a newly-founded
city has zero shield stock).
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24714>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
