Hi Ola, for the patch, I suggest you to submit it to the mailing list. Core developers will review it and if everything is ok they will apply it.
For the class splitting, I would suggest if you first propose a general plan and then work with incremental steps. FreeCol is rather complex stuff, and breaking large classes is easily going to break things. This is my two cents, I think others will give their point of view. Ciao PaoloB On Fri, Aug 17, 2012 at 4:56 PM, Ola Sundell <[email protected]> wrote: > Hello. > > I love playing Freecol and since I work as a Java developer, I wanted to see > if I could help. It has been a while since I last contributed code to an > open source project, but I'm keen to give back to the community - especially > to a game which has given me hours of enjoyment. > > I've fixed a small thing that has been annoying me: when I remove a trade > route stop the selection is removed from the list and I have to click in the > list box anew. Where do I submit a patch for it? > > I've been peeking at the code base and I ran a Sonar run just to do a health > check. Thus far, this is what I've seen: > > Good Things(tm): > > * short but sweet methods > * pretty well-structured packages > * compiling works out of the box > * you've avoided Maven (hooray!) > * quite a bit of javadoc for the public methods > > Smells: > > * Huuuge classes (InGameController is 3866 lines! Yikes!!!) > * Old-ish versions of external libraries > * Code coverage could be a little bit better > * A bit of code duplication here and there. > > All together I would say that from what I've gathered thus far, the code > base is in very good shape would it not be for the gigantic classes. I > humbly ask for permission to start refactoring - would that be of interest? > I would primarily look at breaking those huge classes apart. > > Best regards and warm wishes and huggies > > Ola > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Freecol-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/freecol-developers > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
