On 13.11.2012 22:47, Thierry wrote: > Le lundi 12 novembre 2012 à 07:22 +0100, Michael Vehrs a écrit : > >> On 11.11.2012 19:26, Thierry wrote: >> >>> Hello, >>> >>> I'm new to this list and hope to help. >>> >>> This patch correct the French translation for me (tested in English and >>> French). >>> 4 new messages have to be translated in other languages (not added). >>> >>> Please commit (current r10281. >>> >>> Regards. >>> -- >>> Thierry >>> >>> >> >> Thanks for your patch, which I have applied as commit #10282. Please >> note that the default message file is FreeColMessages.properties (with >> no country or language specification). It contains strings in US English. >> FreeColMessages_en_GB.properties is only used for strings in British >> English (to account for different spelling, for example). You might also >> use Messages.getName(FreeColObject), which returns the localized name of >> the object (adding ".name" to the object's ID). >> >> >> Regards >> >> Michael >> >> > Hello, > > Thanks for your advises. > I need an object's ID to fixe the plural form, so I added a getName > method to the goodsType class. > Is it the right way ? > > Please find the cleanup in attachment (vs.r10286). > > Regards. >
That is unnecessary, since the FreeColGameObjectType class, from which GoodsType is derived, already has the getNameKey method. At present, I think the model classes should not even provide these keys, and that Messages should handle all these cases with only the object ID as input. But that would require some major changes, I fear. Regards Michael ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
