The tile view stuff is standing up fairly well, and the first cut of the XDG et al directory reform has gone in, so on to the big remaining annoyance: what to do about FreeColDialog.getResponse.
Said routine is a hack to make FreeColDialogs non-modal. It seems the right way to do this these days is with JDialog which allows you to specify the modality (as of Java 6). However it is awkward to simply make FreeColDialog extend JDialog as FreeColDialog currently extends FreeColPanel and inherits/uses a bunch of stuff therein. FreeColPanel itself is a JPanel, and is used for a bunch of things: ColopediaPanel ConceptDetailPanel AboutPanel VictoryPanel StatisticsPanel ColopediaGameObjectTypePanel StartGamePanel ColorCellEditor PortPanel NewPanel WorkProductionPanel ServerListPanel CargoPanel ReportPanel IndianSettlementPanel MainPanel InfoPanel StatusPanel BuildQueuePanel ColonyPanel ChatPanel MapEditorTransformPanel TilePanel many of which are just informational with an ok button to dismiss them, but some (StartGamePanel, NewPanel, MainPanel) really should be modal. The current modality is somewhat confused, for example IndianSettlementPanel appears to swallow all keystrokes until dismissed, but you can happily select units and give them orders with the mouse. This suggests that the least disruptive path is to make FreeColPanel extend JDialog, with controllable modality defaulting to non-modal. Does this make sense? Cheers, Mike Pope
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
