On 01/28/2014 10:36 AM, Michael T. Pope wrote: > In BR#2650 there is a bunch of fail around the blinking behaviour of > the current unit. I have cleaned up the immediate problems in > git.209e293, but what is the Right Thing here? My fixes cause the > blinking to stop if in move-units-mode and a modal dialog is raised, > and to restart when there are no longer any modal dialogs displayed. > Previously there appeared to be some attempt to stop blinking if > certain panels were present, but that code had bit rotted. However > now that many panels are positioned so that the current unit is > visible, I think the blinking is more useful now than it was > previously. Obvious choices are a) the current modal-dialogs stop > blinking, b) all dialogs stop blinking, c) all panels of any sort stop > blinking. There may be more. What do you think folks? > > Cheers, > Mike Pope >
Mike, could you clarify the difference between modal dialogs , non-modal dialogs and panels ? Which of those (if any) block user-input that may cause the active map square to change ? I looked at the code and think the actual blinking is implemented through a swing timer in src/net/sf/freecol/client/gui/TerrainCursor.java . Does keeping the blinking active always when map is onscreen hamper performance ? LW ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
