On Tue, 20 Sep 2016 19:45:51 +0930
"Michael T. Pope" <mp...@computer.org> wrote:

> On Tue, 20 Sep 2016 11:37:19 +0200
> Michael Vetter <jub...@openmailbox.org> wrote:
> > I think I spotted a small mistake in the freecol.sh script.
> > You use test -d there which is used to look for a directory.
> > Actually we want to look for a jar file in that directory, so we
> > should use test -r.  
> 
> Good catch.  Applied.

:-)

Oh but you made a small mistake.
If you would have used: git apply
0001-Fix-testing-of-jar-in-FHS-location.patch

Thenn all the author information would have been used. Like this it was
written like its your patch. Some people could either take this the
wrong way (unfair) or generally it helps with git blame if you have
this info :-)

------------------------------------------------------------------------------
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to