Hi, I had mentioned before that I wanted to make combined river styles available in the map editor, as we have the art already and it would give map makers more choices. I implemented it now and would like to have some feedback before I put it into the official repo. https://github.com/wintertime/FreeCol/tree/more-river-styles
I added another button to the map editor panel where all styles are available, but kept the simpler function where you can add/remove river arms, as they work differently. One tries to make the change, the other forces the new style and may add more rivers when you want connections that would otherwise be broken. You think its a good idea to keep both to allow for using the simpler one mostly? Would you change the tooltip text I added to give more information on how it works? A minor problem with the change is that it reintroduces an overly large river style menu. Would you filter out the simple styles from the style button? Or have separate buttons for minor, major and combined styles to reduce the size of the style dialog, even though it might confuse people? Or just add the previously requested scroll bars and be done? I tested that I can add rivers with minor and major river-arms using the map editor now and they also stayed when I saved the map, restarted and reloaded the map. What I still need to test is creating a decent test-map and see if starting a new game with such a map would actually work. Greetings, wintertime ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
