On Sun, 12 Dec 2021 21:35:42 +0100 (CET) Stefan Fellner <stefan.fell...@tutanota.com> wrote: > I have been working on TradeRouteInputPanel the last week and I got it > running now.
Er, the attached patch contains a lot of stuff unrelated to the TRIP.
I am pretty sure the changes to the graphics files are not what you wanted!
I suggest you rebuild the patch, or rather, break it up into multiple
patches, each of which does *one* thing.
For example, the modality hackery is potentially useful, but I am
concerned that isModalFreeColPanelShowing() may turn out to be brittle
(are you *sure* notifyClose covers *all* cases?). If we need to revert
this change, I would prefer it be able to be done easily without also
reverting the fixes to TRIP. Similarly, while
InGameController.unloadUnitAtStop is improved by your better variable
names, code cleanups should be independent of functionality work.
Minor points:
- In UnitLabel you are deleting the unused Logger. Logging comes and
goes:-), so we have a convention if leaving unused loggers around, they
usually get used again soon enough.
- In DragListener:
- System.err.println("DragListener did not recognize:" + comp);
+ logger.log(Level.WARNING, () -> "DragListener did not
recognize:" + comp);
Oops, the System.err.println is a leftover debug trace that I forgot to
remove. I am curious though, why do you use lambda's in loggger
messages?
- Apparently you do not share my appreciation for the ternary operator:-)
Cheers,
Mike Pope
pgpm5qcqrxG9t.pgp
Description: OpenPGP digital signature
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
